Skip to content

Remove QuantizedArray class. #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove QuantizedArray class. #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion qwix/_src/core/qarray.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,9 @@ def take(x: jax.Array) -> jax.Array:
return jax.tree.map(take, array)


_VALID_SCALE_DTYPES = (jnp.float16, jnp.bfloat16, jnp.float32, jnp.float64)


def validate_qarray(array: QArray):
"""Validates the internal consistency of a QArray."""
if not isinstance(array.qvalue, jax.Array):
Expand All @@ -220,7 +223,7 @@ def validate_qarray(array: QArray):
)
if array.qvalue.dtype.itemsize > 1:
raise ValueError(f'{array.qvalue.dtype} is not a valid type for qvalue.')
if array.scale.dtype not in (jnp.bfloat16, jnp.float32, jnp.float64):
if array.scale.dtype not in _VALID_SCALE_DTYPES:
raise ValueError(f'{array.scale.dtype} is not a valid type for scale.')
if array.zero_point is not None:
if array.zero_point.ndim != array.qvalue.ndim:
Expand Down