Open
Conversation
RasoulAM
added a commit
to RasoulAM/private-join-and-compute
that referenced
this pull request
Aug 1, 2022
|
Could you tell me the version of bazel that you use?I try to build this but I fail. |
ruidazeng
reviewed
Jan 24, 2026
| FLAGS_paillier_modulus_size); | ||
|
|
||
| grpc::ChannelArguments ch_args; | ||
| ch_args.SetMaxReceiveMessageSize(-1); // consider limiting max message size |
Member
There was a problem hiding this comment.
Client uses -1 (unlimited), server uses INT_MAX. That’s probably intentional, and using -1 on ServerBuilder historically hasn’t always behaved as people expect, so INT_MAX is defensible.
Still, I’d prefer:
- define a single constant / flag value used in both places, and
- add a short comment explaining why server uses INT_MAX rather than -1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #16.
This is ok for a POC, in real life scenario max message size should obviously be limited.