Skip to content
This repository was archived by the owner on Jan 22, 2025. It is now read-only.

Conversation

@agrandville
Copy link

Let me know about your feedback on those changes.
Best,
Arnaud

@google-cla
Copy link

google-cla bot commented Jun 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jun 29, 2021
@agrandville
Copy link
Author

@googlebot signed !

@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 29, 2021
Copy link
Contributor

@daviddrysdale daviddrysdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR – adding Windows support sounds good.

The general approach seems reasonable, but on a quick first pass through the changes there's a few small details that would be good to get tidied up before merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants