Skip to content

Conversation

@jameseidson
Copy link
Collaborator

@jameseidson jameseidson commented Nov 5, 2025

  • Fix packet generation with multiple constraints
  • Fix generation of >16 bit open enums
  • update examples/android_ranging_oob.pdl

@jameseidson jameseidson force-pushed the fix/multiple-constraints branch from ce1dd0d to 1c519f4 Compare November 12, 2025 19:40
@jameseidson jameseidson changed the title Fix bugged codegen with multiple constraints Fix a few bugs in codegen Nov 12, 2025
@hchataing
Copy link
Collaborator

  1. New clippy warnings :/
  2. Please mention in the commit message that the codegen issues are caused by the java generator

@jameseidson
Copy link
Collaborator Author

jameseidson commented Nov 20, 2025

  1. New clippy warnings :/

I don't see these warnings when running clippy locally, and when I try to make the suggested change I get a compiler error:

error[E0658]: use of unstable library feature `unsigned_is_multiple_of`
   --> pdl-compiler/src/backends/rust/decoder.rs:143:23
    |
143 |         if self.shift.is_multiple_of(8) {
    |                       ^^^^^^^^^^^^^^
    |
    = note: see issue #128101 <https://github.com/rust-lang/rust/issues/128101> for more information

Looks like the compiler is configured differently for local builds than it is for CI builds. Can you fix this?

@jameseidson jameseidson changed the title Fix a few bugs in codegen Fix a few bugs in java codegen Nov 20, 2025
@jameseidson jameseidson force-pushed the fix/multiple-constraints branch from 1c519f4 to e3375b0 Compare November 20, 2025 21:41
@hchataing
Copy link
Collaborator

I have updated the Clippy rule to use the same version as the rust compiler in the Build rule.
That should prevent new warnings from popping up in the future.

- Packet with multiple constraints
- Enum static factory when larger than 8 bits
@hchataing hchataing force-pushed the fix/multiple-constraints branch from e3375b0 to 6d58ceb Compare November 26, 2025 09:58
@hchataing hchataing enabled auto-merge (rebase) November 26, 2025 10:01
@hchataing hchataing disabled auto-merge November 26, 2025 10:18
@hchataing hchataing merged commit 0bdf67c into main Nov 26, 2025
9 checks passed
@hchataing hchataing deleted the fix/multiple-constraints branch November 26, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants