Add all common parameters to context definition and make gl.getParameter support. #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efinition, make method gl.getParameter support int32array and float32array return value. fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes. feat(webgl_extensions): Add WEBGL_draw_buffers extension. feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
…port GLboolean, GLboolean[], BINDING(or null), and etc. feat(test): Add src/tests/get_parameter_test.ts script. feat(egl_context_wrapper): Add method glGetBooleanv to get boolean parameter value(s).
nkreeger
reviewed
Apr 16, 2020
Contributor
nkreeger
left a comment
nkreeger
left a comment
There was a problem hiding this comment.
Sorry I was out on leave and missed this!
Just a few comments, thank you for this detailed PR!
| const { name, type, subType, length, /*nullable,*/ extension } = parameterDefinition; | ||
| let ptarget: any = gl, pname: GLenum; | ||
| const result = new VerifyResult(); | ||
| // if (name === 'DRAW_BUFFER?_WEBGL') return verifyDrawBuffersWebgl(gl, parameterDefinition); |
| value = gl.getParameter(pname); | ||
| } | ||
| catch (error) { | ||
| // return result.setObject(error); |
| let numPassed = 0; | ||
| parameterDefinitions.forEach((parameterDefinition, index) => { | ||
| const result = verifyParameterDefinition(gl, parameterDefinition); | ||
| result.passed ? process.stdout.write(`\u001b[92m`) : process.stdout.write(`\u001b[91m`); |
Contributor
There was a problem hiding this comment.
Looks like some formatting problems here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(webgl_rendering_context): Add all common parameters to context definition, make method gl.getParameter support int32array and float32array return value.
fix(webgl_rendering_context): Fix the return value of method gl.getContextAttributes.
feat(webgl_extensions): Add WEBGL_draw_buffers extension.
feat(egl_context_wrapper): Add method glGetFloatv to get float parameter value(s).
This change is