Include files in the directory of src#8
Merged
torj9n merged 1 commit intogoogle:mainfrom Jan 21, 2025
Merged
Conversation
mpact_isa_decoder() and mpact_bin_fmt_decoder() uses the working directory to find files to include, but it is unreliable the working directory will vary if the repository containing the source files is nested. To avoid this unreliability, always include files in the directory of src.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mpact_isa_decoder() and mpact_bin_fmt_decoder() uses the working directory to find files to include, but it is unreliable the working directory will vary if the repository containing the source files is nested.
To avoid this unreliability, always include files in the directory of src.
See also: akihikodaki/mpact-riscv@6520b5e