Deprecate ZetaSQL-based filter_query functionality for v1.19.0 removal
#226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate filter_query parameter in ListOperationOptions that depends on ZetaSQL. Add runtime warnings (Python DeprecationWarning, C++ LOG(WARNING)), update documentation, and add test coverage for deprecation warnings. This prepares for removal of ZetaSQL dependency in version 1.19.0.
czgdp1807
changed the title
ZetaSQL-based filter_query functionality for v1.19.0 removal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive deprecation warnings for the
filter_queryparameter inListOperationOptionsthat depends on ZetaSQL. This prepares for the removal of ZetaSQL dependency from ML Metadata in version 1.19.0.Motivation
ZetaSQL dependency is being phased out from ML Metadata. The
filter_queryfeature relies on ZetaSQL for SQL query parsing and analysis. To maintain backward compatibility while communicating the planned removal, this PR adds proper deprecation warnings across the codebase.Changes
Runtime Warnings
metadata_store.py): AddedDeprecationWarningwhenfilter_queryis used inListOptionsLOG(WARNING)messages in:query_config_executor.cc(MySQL)postgresql_query_executor.cc(PostgreSQL)Documentation Updates
filter_queryas deprecated with migration guidancefilter_query_ast_resolver.hand.ccfilter_query_builder.hand.ccTest Updates
test_get_nodes_by_filter_queryto verifyDeprecationWarningis raisedtest_get_nodes_by_filter_query_syntax_errorsto verify warnings even on syntax errorswarnings.catch_warnings()) to lineage subgraph tests that usefilter_queryfor backward compatibility testingTimeline
filter_queryand ZetaSQL dependencyTesting
All tests pass with proper deprecation warning handling:
filter_queryis usedMigration Path
Users relying on
filter_queryshould migrate to alternative filtering approaches before v1.19.0. The deprecation warnings provide clear guidance on the timeline and necessary actions.