Skip to content

Fix missing order by fields in SELECT statement #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antisaling wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

Fix missing order by fields in SELECT statement #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ml_metadata/metadata_store/postgresql_query_executor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ absl::Status PostgreSQLQueryExecutor::ListNodeIDsUsingOptions(
sql_gen_status.message()));
}
sql_query = absl::Substitute(
"SELECT distinct $0.id, $0.create_time_since_epoch FROM $1 WHERE $2 "
"SELECT distinct $0.id, $0.create_time_since_epoch, $0.last_update_time_since_epoch FROM $1 WHERE $2 "
"AND ",
*node_table_alias,
// TODO(b/257334039): remove query_version-conditional logic
Expand Down
2 changes: 1 addition & 1 deletion ml_metadata/metadata_store/query_config_executor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,7 +844,7 @@ absl::Status QueryConfigExecutor::ListNodeIDsUsingOptions(
sql_gen_status.message()));
}
sql_query = absl::Substitute(
"SELECT distinct $0.`id` FROM $1 WHERE $2 AND ", *node_table_alias,
"SELECT distinct $0.`id`, $0.`create_time_since_epoch`, $0.`last_update_time_since_epoch` FROM $1 WHERE $2 AND ", *node_table_alias,
// TODO(b/257334039): remove query_version-conditional logic
query_builder.GetFromClause(query_version),
query_builder.GetWhereClause());
Expand Down