Skip to content

Conversation

@amitmukati-2604
Copy link

No description provided.

@lehrig
Copy link

lehrig commented Feb 15, 2023

Note that this PR is part of a greater effort to enable Kubeflow and all its dependencies for multiple processor architectures (we start with ppc64le): kubeflow/community#781

@BrianSong
Copy link
Contributor

Hi @lehrig, I have transferred to another team. Please reach out to @ryanpeters-google as he is the owner for MLMD OSS now.

@lehrig
Copy link

lehrig commented Mar 9, 2023

Alright, so @ryanpeters-google, are we good to proceed here?

@ryanpeters-google
Copy link
Collaborator

Due to an internal issue unrelated to the content of this PR, I am unable to test your change at this time. I am working to resolve the issue internally. Targeting Q2 for resolution.

@pranavpandit1
Copy link

@ryanpeters-google: Any updates on this request?
cc @lehrig @amitmukati-2604

Copy link
Contributor

@XinranTang XinranTang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM :) Could you provide some end-to-end results to show how you are able to build MLMD on ppc64le platforms?

unzip \
software-properties-common \
git \
openjdk-8-jdk
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
openjdk-8-jdk
openjdk-8-jdk \

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this dependency is needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need this dependency because bazel binary for linux/ppc64le needs java.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@XinranTang - does that clarify your question?

@thesuperzapper
Copy link

thesuperzapper commented Dec 14, 2023

I believe my PR #188 (for ARM64) could be extended with PPC64 support once merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants