Use the baseline cache for the sampling evaluator#550
Merged
Conversation
mtrofin
requested review from
boomanaiden154 and
svkeerthy
and removed request for
svkeerthy
mtrofin
changed the base branch from
spr/mtrofin/main.use-the-baseline-cache-for-the-sampling-evaluator
to
main
mtrofin
force-pushed
the
spr/mtrofin/use-the-baseline-cache-for-the-sampling-evaluator
branch
from
dc06f36 to
5f3a0f7
Compare
boomanaiden154
approved these changes
Feb 18, 2026
Collaborator
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Overall LGTM, one question, one nit.
| not_done, return_when=concurrent.futures.FIRST_COMPLETED) | ||
| return futures | ||
|
|
||
| def ensure_baselines(self, pool): |
Collaborator
There was a problem hiding this comment.
Nit: naming seems a bit weird. I feel like something like compute_baselines would fit a bit better.
Collaborator
Author
There was a problem hiding this comment.
it doesn't compute if they are computed.
Collaborator
There was a problem hiding this comment.
Maybe get_baselines then? Either way we still setup self._baselines.
Collaborator
Author
There was a problem hiding this comment.
get_baselines suggests something is returned, but it's not. Also, suggests simple accessor, and also const-ness. Neither are true.
ensure says what it does.
mtrofin
deleted the
spr/mtrofin/use-the-baseline-cache-for-the-sampling-evaluator
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.