Improve ai21labs/AI21-Jamba-1.5-Large support #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochafik
referenced
this pull request
in ochafik/minja
Nov 2, 2025
Improve ai21labs/AI21-Jamba-1.5-Large support
CISC
pushed a commit
to aldehir/minja
that referenced
this pull request
Dec 20, 2025
…le#15) ## Summary This PR fixes multiple CI issues to get all builds passing on Windows, macOS, and Linux. ## Changes ### Workflow Fixes - **Branch trigger**: Changed from `master` to `main` - **Sanitizer exclusions**: Added exclusions for MSVC ARM64 builds (address/thread/undefined sanitizers not supported) ### Build Fixes - **Disabled clang-tidy for address sanitizer builds**: Avoids GCC `-Wno-maybe-uninitialized` flag incompatibility with clang-tidy - **Disabled cppcheck on Windows**: Fixes `std.cfg` not found error - **Added `-Wa,-mbig-obj` for MinGW Debug builds**: Fixes COFF section limit exceeded error (>65535 sections) ### Python/Encoding Fixes - **Added `PYTHONIOENCODING=utf-8`** to Configure and Test steps for Windows Unicode support - **Added `encoding='utf-8'`** to all file operations in `fetch_templates_and_goldens.py` - **Added `newline='\n'`** to force Unix line endings in generated files ### Test Fixes - **Normalize actual template output**: Apply `normalize_newlines()` to actual output in tests - **Windows blank line workaround**: Added `collapse_blank_lines()` for Windows due to a known issue where C++ minja outputs fewer newlines than Python Jinja2 (tracked in google#16) ## Related Issues - google#16 - Windows: C++ minja outputs fewer newlines than Python Jinja2 ## Test Plan - [x] All 28 CI jobs pass (Windows, macOS, Linux with various sanitizers and build types) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work is needed, but here's already:
*intfilter#8