Improve support for fireworks-ai/llama-3-firefunction-v2 #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ochafik
changed the title
ochafik
referenced
this pull request
in ochafik/minja
Nov 2, 2025
Improve support for fireworks-ai/llama-3-firefunction-v2
CISC
pushed a commit
to aldehir/minja
that referenced
this pull request
Dec 20, 2025
) ## Summary Implements support for DeepSeek V3.2's DSML (Domain Specific Markup Language) format, superseeds google#11 (cc/ @hksdpc255) DeepSeek V3.2 doesn't provide a Jinja template but uses a custom Python encoding with DSML format: ```xml <｜DSML｜parameter name="key" string="true">value</｜DSML｜parameter> ``` ## Changes - **Simplified argument needle detection**: Changed from specific patterns (`"argument_needle":`, `="argument_needle"`) to broader `"argument_needle"` pattern which matches both JSON keys and DSML attribute values - **Local .jinja file support**: Fetch script now handles local `.jinja` files in MODEL_IDS (for synthetic test templates) - **Synthetic template**: Added `synthetic-deepseek-v3.2-dsml.jinja` replicating V3.2's Python encoding logic (from `encoding_dsv32.py`) - **Integrated testing**: Added synthetic template to MODEL_IDS, generates 3 test cases (simple, system, tool_use) ## Test plan - [x] All 248 tests pass - [x] Capability detection correctly identifies DSML format (`supports_tool_calls: true`, `requires_object_arguments: true`) - [x] Synthetic template tests pass for all contexts Closes google#11 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost fixes #7
This adds the following features:
+Still some issues w/
functionsanddatetimeexpected in template (crashes jinja2), which get resolved to None if I add them in the context. Will do a follow up PR.