fix possible overflows #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ram-mohan
force-pushed
the
overflow
branch
2 times, most recently
from
2016f00 to
f0bb225
Compare
Collaborator
|
Hi Ram, I find this change has both fixing overflows and changing color coefficients, and both parts are not related I would recommend we separate those into two CLs |
The data type that was used to store the memory required for input raw buffers was int. This works for normal dimensions. For images where width and height are very large, say greater than 32768, then rgb input buffer size is 32768 * 32768 * 4. This computation exceeds integer max causing issues. This change addresses this by assigning the type for widths/heights/strides/ as unsigned int and buffer sizes as size_t Test: ./ultrahdr_unit_test
Contributor
Author
Sure Dichen, i have updated the change as per the suggestion. |
DichenZhang1
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.