Fix GOOGLE_PROTOBUF_VERSION comparisons #279
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To check the feature: 1. checkout to the first commit where feature was available 2. find value of `GOOGLE_PROTOBUF_VERSION`, call it `V` 3. Use strict `(GOOGLE_PROTOBUF_VERSION > V)`, as there are commits where `GOOGLE_PROTOBUF_VERSION == V`, but features is not there yet.
hartwork
suggested changes
Feb 25, 2025
Contributor
There was a problem hiding this comment.
@vitalybuka this seems mistaken, I used git tag --contains and checked out those to avoid the very problem you're describing. Any value at non-release commits will be misleading and has potential for false positive matches. Please do not do this 🙏
Collaborator
Author
|
abandoning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To pick constant to check I use:
GOOGLE_PROTOBUF_VERSION, call itV(GOOGLE_PROTOBUF_VERSION > V), asthere are commits where
GOOGLE_PROTOBUF_VERSION == V,but features is not there yet.