Remove dependency on KotlinCompile.libraries #2748
Conversation
hfmehmed
force-pushed
the
update-libraries-input
branch
3 times, most recently
from
6d4a801 to
9fa3b6b
Compare
hfmehmed
force-pushed
the
update-libraries-input
branch
from
9fa3b6b to
42e23de
Compare
| cfg.libraries.from( | ||
| project.files( | ||
| Callable { | ||
| kotlinCompileProvider.get().libraries.filter { |
There was a problem hiding this comment.
If KotlinCompile.libraries is going to be removed, do you have a schedule of removing the else part?
There was a problem hiding this comment.
I havent had a chance to think about it yet. There is 2 things that need to be answered:
- Is the alternative (the if case) a satisfactory replacement for this?
- Will KGP provide separate API similar to KotlinCompile.libraries but one that will exclude kapt
If KGP implements the new API we can move to it as soon as it is released. Otherwise I believe we need some time (so users can test this) to determine if the alternative really covers all edge cases out there
| ) | ||
| configuration.incoming.artifactView { config -> | ||
| config.attributes.attribute( | ||
| Attribute.of("artifactType", String::class.java), "android-classes-jar" |
There was a problem hiding this comment.
Looks like a bug in AGP or KGP to me. Why isn't artifactType properly set in configuration?
There was a problem hiding this comment.
As far as i understand the consumer of a specific configuration needs to define what artifactType they want to consume. So here we have KSP saying please give me the incoming dependencies from this configuration, and i only want to see classes jar even if the dependency contains much more. So i dont think this is a bug on the producer side of this configuration (which is KGP)
2 participants
Fixes a circular dependency in KSP when in use with legacy-kapt plugin
KotlinCompile.libraries contains the output classes dir of kapt. Since this is a lazy gradle api, filtering does not remove the task dependency so ksp ends up depending on kapt. KAPT itself depends on KSP so this leads to a circular dependency.
Instead use KotlinCompilation.compileDependencyFiles which only contains the compilation jars. On top we need to add the android bootclasspath (containing android.jar and build tools jar)
Fixes #2743