Fix detection of android base plugin usage #2747
Closed
+41
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ting-yuan
reviewed
Jan 9, 2026
| decorateAndroidExtension(project, onSourceSet) | ||
| } | ||
| } catch (e: Throwable) { | ||
| // Android plugin not found, ignore |
Collaborator
There was a problem hiding this comment.
It is too broad and may bite us in the future. Is it feasible to catch the specific exception type and make sure it is because of AndroidBasePlugin?
hfmehmed
force-pushed
the
fix-agp-detection-2
branch
from
817b99a to
568ce93
Compare
Collaborator
Author
|
Actually i am still unconvinced we should do this. Lets wait until i get more clarity what is happening here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying settings plugins (that come from composite gradle build), some classloader change leads to "com.android.base" plugin not being detected as applied by Gradle, leading to problems.
When using the plugins.withType(Class) API this works, however now we face a Class not found error if the AGP plugin is not applied. So everything is wrapped in a try catch block.