Create a media module with MediaRepository #326
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimblebee
reviewed
Mar 17, 2025
data/media/src/main/kotlin/com/google/jetpackcamera/data/media/LocalMediaRepository.kt
Show resolved
Hide resolved
data/media/src/main/kotlin/com/google/jetpackcamera/data/media/MediaRepository.kt
Outdated
Show resolved
Hide resolved
data/media/src/main/kotlin/com/google/jetpackcamera/data/media/MediaRepository.kt
Outdated
Show resolved
Hide resolved
data/media/src/main/kotlin/com/google/jetpackcamera/data/media/MediaRepository.kt
Outdated
Show resolved
Hide resolved
data/media/src/main/kotlin/com/google/jetpackcamera/data/media/MediaRepository.kt
Outdated
Show resolved
Hide resolved
Kimblebee
reviewed
Mar 19, 2025
data/media/src/main/kotlin/com/google/jetpackcamera/data/media/MediaRepository.kt
Show resolved
Hide resolved
Jaehwa-Noh
reviewed
Mar 21, 2025
| */ | ||
| package com.google.jetpackcamera.data.media | ||
|
|
||
| class LocalMediaRepository : MediaRepository { |
Contributor
There was a problem hiding this comment.
Need to use Hilt @Inject constructor()
Collaborator
There was a problem hiding this comment.
this class doesn't currently have any parameters, so I don't think this is necessary.
Comment on lines
+31
to
+33
| @Provides | ||
| @Singleton | ||
| fun provideMediaRepository(): MediaRepository = LocalMediaRepository() |
Contributor
There was a problem hiding this comment.
I think it should be use @Binds, rather than @Provides.
@Binds
@Singleton
fun provideMediaRepository(localMediaRepository : LocalMediaRepository): MediaRepository
Collaborator
There was a problem hiding this comment.
I think @Provides is fine here because this is a class method, not an interface/abstract.
Kimblebee
approved these changes
Mar 25, 2025
| */ | ||
| package com.google.jetpackcamera.data.media | ||
|
|
||
| class LocalMediaRepository : MediaRepository { |
Collaborator
There was a problem hiding this comment.
this class doesn't currently have any parameters, so I don't think this is necessary.
Comment on lines
+31
to
+33
| @Provides | ||
| @Singleton | ||
| fun provideMediaRepository(): MediaRepository = LocalMediaRepository() |
Collaborator
There was a problem hiding this comment.
I think @Provides is fine here because this is a class method, not an interface/abstract.
Fill out the MediaRepository interface
Change Media and MediaDescriptor into interfaces Add more KDoc Add object Error to Media
yasith
force-pushed
the
yasith/mediaRepository
branch
from
5433415 to
1a16a3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MediaRepositorythat can be used to query MediaStore for media created by JCA.It'll be used for showing the media thumbnails in
PreviewScreen, and for displaying the media items inPostCaptureScreen.Implementation in #328
Usage in #330