Enhance Operator Robustness and Expand Supported Ops#190
Open
srmurali002 wants to merge 6 commits intogoogle:mainfrom
Open
Enhance Operator Robustness and Expand Supported Ops#190srmurali002 wants to merge 6 commits intogoogle:mainfrom
srmurali002 wants to merge 6 commits intogoogle:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance Operator Robustness and Expand Supported Ops
Summary
This PR introduces a robust version fallback mechanism for operator handlers and expands support for several key ONNX operators, including a new implementation of HardSigmoid. These changes improve the library's future-proofing and compatibility with modern ONNX models (e.g., RTMPose).
Key Changes
1. Robust Version Fallback Mechanism (handler.py)
Handler.handleto implement a highest-supported-version fallback.NotImplementedErrorwhen running models with newer opsets (e.g., opset 22/25) that haven't changed specific operator semantics since their last implemented version.2. New Operator: HardSigmoid
3. Operator Fixes and Version Updates
minandmaxas positional inputs (consistent with newer ONNX specs).axesattribute handling to ensure consistency with ONNX expectations for opset 11+.4. Standards and Quality
pylintwith a 10.00/10 score, adhering strictly to the Google Python Style Guide.Verification Results
Unit Tests
test_hardsigmoid_patterns to tests/onnx_ops_test.py.Checklist
pylint.