Remove snapshot repositories from guava-gwt configuration.
#8137
+0
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added these back in cl/99780060 so that we could depend on a GWT snapshot release, and we had to switch from the GWT snapshot release to a beta release soon after so that we could actually publish a release of Guava. But ever since they were introduced, these snapshot lines have been forcing our builds to consult those snapshot repositories for all our dependencies, it seems, as Gemini observed from the log files! That somehow became even slower recently, so changes from 06376ba onward have taken close to an hour for their CI. (I wonder if the newfound slowness is related at all to the OSSRH turndown? Or maybe it's about some other turndown or who knows what else.) I think that removing them will change nothing except for dramatically speeding up our builds, at least in CI and perhaps locally, too. RELNOTES=n/a PiperOrigin-RevId: 849278261
copybara-service
bot
force-pushed
the
test_849272321
branch
from
809fe3a to
d8aef62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove snapshot repositories from
guava-gwtconfiguration.We added these back in cl/99780060 so that we could depend on a GWT snapshot release, and we had to switch from the GWT snapshot release to a beta release soon after so that we could actually publish a release of Guava. But ever since they were introduced, these snapshot lines have been forcing our builds to consult those snapshot repositories for all our dependencies, it seems, as Gemini observed from the log files! That somehow became even slower recently, so changes from 06376ba onward have taken close to an hour for their CI. (I wonder if the newfound slowness is related at all to the OSSRH turndown? Or maybe it's about some other turndown or who knows what else.)
I think that removing them will change nothing except for dramatically speeding up our builds, at least in CI and perhaps locally, too.
RELNOTES=n/a