Fix errors caused by immutable.js v4 to v5 upgrade

web/src/app/components/create-survey/create-survey.component.ts

@@ -383,12 +383,12 @@ export class CreateSurveyComponent implements OnInit {
     // Assume the survey exists.
     const survey = this.survey!;
 
-    await this.taskService.addOrUpdateTasks(
-      survey.id,
-      // Assume there is at least one job.
-      survey.jobs.first(),
-      tasks!
-    );
+    const job = survey.jobs.first();
+    if (!job) {
+      console.error('Cannot save tasks: survey has no jobs', survey.id);
+      return;
+    }
+    await this.taskService.addOrUpdateTasks(survey.id, job, tasks!);
   }
 
   private async saveDataSharingTerms(): Promise<void> {

web/src/app/components/main-page-container/main-page/drawing-tools/drawing-tools.component.spec.ts

@@ -182,7 +182,7 @@ describe('DrawingToolsComponent', () => {
       expect(
         authServiceSpy.canUserAddPointsToJob(
           mockSurvey,
-          mockSurvey.jobs.first()
+          mockSurvey.jobs.first()!
         )
       ).toBe(false);
 

web/src/app/components/main-page-container/main-page/drawing-tools/drawing-tools.component.ts

@@ -61,7 +61,7 @@ export class DrawingToolsComponent implements OnInit, OnDestroy {
   polygonValue = 'polygon';
   selectedValue = '';
   private lastSelectedValue = '';
-  selectedJobId = '';
+  selectedJobId: string | undefined = '';
 
   readonly jobs = computed(() => {
     const survey = this.survey();

web/src/app/components/main-page-container/main-page/side-panel/submission-form/submission-form.component.ts

@@ -311,9 +311,7 @@ export class SubmissionFormComponent implements OnChanges {
     task: Task,
     result?: Result
   ): void {
-    const selectedOptionId = (
-      (result?.value as MultipleSelection)?.values.first() as Option
-    )?.id;
+    const selectedOptionId = (result?.value as MultipleSelection)?.values.first();
     group[task.id] = task.required
       ? new FormControl(selectedOptionId, Validators.required)
       : new FormControl(selectedOptionId);

web/src/app/components/shared/share-list/share-list.component.spec.ts

@@ -85,7 +85,7 @@ describe('ShareListComponent', () => {
         'title',
         'description',
         Map(),
-        Map({ [user.email]: Role.VIEWER }),
+        Map([[user.email, Role.VIEWER]]),
         'owner-email',
         { type: DataSharingType.PRIVATE }
       )

web/src/app/converters/loi-data-converter.ts

@@ -36,7 +36,7 @@ function propertiesPbToModel(pb: {
       properties[k] = v;
     }
   }
-  return Map(properties);
+  return Map(Object.entries(properties));
 }
 
 export function loiDocToModel(

web/src/app/converters/submission-data-converter.ts

@@ -57,7 +57,7 @@ function taskDataPbArrayToModel(pb: Pb.ITaskData[]): SubmissionData {
     }
   });
 
-  return Map(submissionData);
+  return Map(Object.entries(submissionData));
 }
 
 function taskDataPbToModel(taskData: Pb.ITaskData): Result | null {

web/src/app/models/loi.model.ts

@@ -28,7 +28,9 @@ export class LocationOfInterest {
     readonly predefined: boolean = true
   ) {}
 
-  static getSmallestByArea(lois: List<LocationOfInterest>): LocationOfInterest {
+  static getSmallestByArea(
+    lois: List<LocationOfInterest>
+  ): LocationOfInterest | undefined {
     return lois
       .sort((a, b) =>
         (a.geometry?.getArea() || 0) < (b.geometry?.getArea() || 0) ? -1 : 1

web/src/app/services/survey/survey.service.spec.ts

@@ -221,7 +221,7 @@ describe('SurveyService', () => {
         'title',
         'desc',
         Map(),
-        Map({ [mockUser.email]: Role.SURVEY_ORGANIZER }),
+        Map([[mockUser.email, Role.SURVEY_ORGANIZER]]),
         'ownerId',
         { type: DataSharingType.PRIVATE }
       );
@@ -234,7 +234,7 @@ describe('SurveyService', () => {
         'title',
         'desc',
         Map(),
-        Map({ [mockUser.email]: Role.OWNER }),
+        Map([[mockUser.email, Role.OWNER]]),
         'ownerId',
         { type: DataSharingType.PRIVATE }
       );
@@ -247,7 +247,7 @@ describe('SurveyService', () => {
         'title',
         'desc',
         Map(),
-        Map({ [mockUser.email]: Role.VIEWER }),
+        Map([[mockUser.email, Role.VIEWER]]),
         'ownerId',
         { type: DataSharingType.PRIVATE }
       );