Skip to content

Fix type annotations for ArrayRecordDataSource. #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tillahoffmann wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix type annotations for ArrayRecordDataSource. #1190

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions grain/_src/python/data_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@
class ARDataSource:
def __init__(self, *args, **kwargs):
raise RuntimeError("array_record isn't supported on Windows")

def __len__(self) -> int:
raise RuntimeError("array_record isn't supported on Windows")

def __getitem__(self, index: int) -> bytes:
raise RuntimeError("array_record isn't supported on Windows")
else:
from array_record.python.array_record_data_source import (
ArrayRecordDataSource as ARDataSource,
Expand Down Expand Up @@ -111,8 +117,8 @@ def __init__(
_api_usage_counter.Increment("ArrayRecordDataSource")

@dataset_stats.trace_input_pipeline(stage_category=dataset_stats.IPL_CAT_READ)
def __getitem__(self, record_key: SupportsIndex) -> bytes:
data = super().__getitem__(record_key)
def __getitem__(self, index: int) -> bytes:
data = super().__getitem__(index)
_bytes_read_counter.IncrementBy(len(data), "ArrayRecordDataSource")
return data

Expand Down