Fix incorrect Resolution() return identified by basic unit test. #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the comparison between the handler nanoSecsFactor. Now, the nanoSecsFactor logic behaves as in the `OpenOffline` function. Add a basic unit test for verification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings gopacket team,
this is my first pull request to gopacket.
The PR/commit/contribution is fairly simple: the
Resolution()getter for theHandletype was incorrectly returning the timestamp precision for any PCAP file. This PR/commit/contribution fixes the bug, while also providing a unit test that checks it.I've followed your programming and contribution guidelines as much as possible.
Waiting for your feedback.