EXCEPT DISTINCT parsed to EXCEPT ALL + order_by and window_frame are an optional field#82
Open
JordyHeusdensDT wants to merge 3 commits intogoogle:masterfrom
Open
EXCEPT DISTINCT parsed to EXCEPT ALL + order_by and window_frame are an optional field#82JordyHeusdensDT wants to merge 3 commits intogoogle:masterfrom
JordyHeusdensDT wants to merge 3 commits intogoogle:masterfrom
Conversation
JordyHeusdensDT
commented
Jan 7, 2022
JordyHeusdensDT
commented
- EXCEPT DISTINCT is mapped to EXCEPT ALL after being parsed, this is now fixed
- order_by in ResolvedAnalyticFunctionGroup can be NULL and should thus be optional
- window_frame in ResolvedAnalyticFunctionCall can be NULL and should thus be optional
This was referenced Jan 7, 2022
|
This solves some bugs I've been having for quite a while |
tristan-vt
approved these changes
Jan 7, 2022
matthewcbrown
pushed a commit
that referenced
this pull request
Feb 16, 2022
Major changes:
We now require bazel 4.0.0
GRPC and Protobuf have been upgraded
- Older version may still work, but are not being tested
Mac builds should be improved
WORKSPACE management is different (if you require java), please
see WORKSPACE file for more info
maven_install rule is now used for java dependencies, which may
affect how bazel-based java builds work.
--
Change by Matthew Brown <matthewbr@google.com>:
Fix some spammy warnings in ZetaSQL
--
Change by ZetaSQL Team <no-reply@google.com>:
Fix interactions between joins and value tables
--
Change by ZetaSQL Team <no-reply@google.com>:
Use the KW_EXCEPT_IN_SET_OP constant rather than a string in the grammar.
--
Change by Matthew Brown <matthewbr@google.com>:
Fix macos Builds in ZetaSQL
- Clang-based builds (like the default on mac) seem to have trouble with
some of the gcc-style warning suppression - so we just spam out
all the warnings.
- Some high-frequency warnings will be cleaned up in a follow-on CL
--
Change by ZetaSQL Team <no-reply@google.com>:
Add annotation to error message when casting a STRING to INTERVAL, which is not a valid INTERVAL value.
--
Change by ZetaSQL Team <no-reply@google.com>:
Fixes SqlBuilder component for `EXCEPT DISTINCT` statements and adds a regression test.
Bug identified by GitHub user @JordyHeusdensDT and fix first proposed in #82
--
Change by ZetaSQL Team <no-reply@google.com>:
INTERNAL
--
Change by ZetaSQL Team <no-reply@google.com>:
rename tvf_bad_call_error_message to mismatch_message.
--
Change by Matthew Brown <matthewbr@google.com>:
ZetaSQL: Upgrade GRPC
--
Change by ZetaSQL Team <no-reply@google.com>:
Switch Value::Struct to Value::MakeStruct to handle errors gracefully.
--
Change by ZetaSQL Team <no-reply@google.com>:
INTERNAL
--
Change by Matthew Brown <matthewbr@google.com>:
ZetaSQL: Upgrade several java dependencies to newer versions
--
Change by ZetaSQL Team <no-reply@google.com>:
Remove some dead code.
--
Change by Matthew Brown <matthewbr@google.com>:
Stop storing a pointer to language options (make a copy instead)
--
Change by Matthew Brown <matthewbr@google.com>:
Propagate language options into parser when resolving TemplatedSqlUdf
--
Change by ZetaSQL Team <no-reply@google.com>:
Add COTH to ZetaSQL as part of adding new math functions
--
Change by ZetaSQL Team <no-reply@google.com>:
Add SECH to ZetaSQL as part of adding new math functions
--
Change by ZetaSQL Team <no-reply@google.com>:
Add CSCH to ZetaSQL as part of adding new math functions
--
Change by Matthew Brown <matthewbr@google.com>:
ZetaSQL: Require bazel 4.0.0+
--
Change by ZetaSQL Team <no-reply@google.com>:
Fix RET_CHECK failure in ResolveArrayElement related to FLATTEN.
--
Change by ZetaSQL Team <no-reply@google.com>:
Documentation for braced new constructors.
--
Change by Matthew Brown <matthewbr@google.com>:
ZetaSQL: Update protobuf version to 3.19.3
GitOrigin-RevId: 185a07d6cd6ba697ac569f3df298f9a38b24e51c
Change-Id: I454d4947229bb3aa51706923e37f55ab0919eb0b
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.