Avoid resetting config options to nil on error #193
Merged
+34
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ram Damera <ramdamera@google.com>
nguyen-phillip
approved these changes
Jan 20, 2026
Collaborator
nguyen-phillip
left a comment
nguyen-phillip
left a comment
There was a problem hiding this comment.
Thanks! LGTM, though please consider enshrining the new behavior with a short test in settings_test.go for this.
Collaborator
Author
|
I tried separate tests for a failures, but for some reason the global variable in the settings package were being overriden by the individual tests even when I'll try again with sub tests that call |
Signed-off-by: Ram Damera <ramdamera@google.com>
Signed-off-by: Ram Damera <ramdamera@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.