Prepare ecdsa code for Go 1.26 deprecations#423
Draft
Foxboron wants to merge 4 commits intogoogle:mainfrom
Draft
Prepare ecdsa code for Go 1.26 deprecations#423Foxboron wants to merge 4 commits intogoogle:mainfrom
Foxboron wants to merge 4 commits intogoogle:mainfrom
Conversation
chrisfenner
reviewed
Jan 7, 2026
Member
chrisfenner
left a comment
chrisfenner
left a comment
There was a problem hiding this comment.
Thank you so much for the proactive fix! I see no big issues here, just a couple minor comments. WDYT about making the breaking change non-breaking by renaming the function?
Foxboron
commented
Jan 7, 2026
The Go crypto APIs for ECC is moving away from using big.Int to pure byte arrays. Deprecate ECCPoint in favour of ECCBytes. Removed the duplicate internal getXY function. Signed-off-by: Morten Linderud <morten@linderud.pw>
Go 1.26 is going to deprecate the X/Y/D fields. Move all usage of this into the new byte handling and new functions. Signed-off-by: Morten Linderud <morten@linderud.pw>
Signed-off-by: Morten Linderud <morten@linderud.pw>
Foxboron
force-pushed
the
morten/nistec
branch
from
40a3b46 to
75ef75c
Compare
Signed-off-by: Morten Linderud <morten@linderud.pw>
Contributor
Author
|
Okay, I do not understand why The code should be fine though |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go 1.26 is going to deprecate the
X,YandDfields inecdsakeys. So these are some patches to start moving things over. The goal is to get some early feedback on approaches or issues with the proposed changes.Most notably I've moved
ECCPointsfrom returning*big.Intto[]bytewhich is what the new APIs are going to expect when dealing with raw bytes. This also simplifies the handling of our ECC points.I haven't looked at the
legacy/tpm2usage yet, but if the approach is fine I'll add some patches there as well.