[KeyManager] Add KeyClaims proto and generation script.#671
Open
atulpatildbz wants to merge 1 commit intogoogle:mainfrom
Open
[KeyManager] Add KeyClaims proto and generation script.#671atulpatildbz wants to merge 1 commit intogoogle:mainfrom
atulpatildbz wants to merge 1 commit intogoogle:mainfrom
Conversation
adds the `KeyClaims` proto definition in `keymanager/km_common/proto/` which includes `VmAttestation`, `KeyAttestation`, and related messages for key protection and attestation. It also adds `proto/gen_keymanager.sh` to generate Go code for keymanager protos.
alexmwu
reviewed
Feb 20, 2026
Contributor
alexmwu
left a comment
alexmwu
left a comment
There was a problem hiding this comment.
VM Attestation message and dependencies belong in https://github.com/GoogleCloudPlatform/confidential-space/tree/main/server not here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds the
KeyClaimsproto definition inkeymanager/km_common/proto/which includesVmAttestation,KeyAttestation, and related messages for key protection and attestation.It also adds
proto/gen_keymanager.shto generate Go code for keymanager protos.