Extract EFIBootServicesApplication events from PCR4 and validate EFI_ACTION as described in the spec#19
Closed
yawangwang wants to merge 1 commit intogoogle:mainfrom
Closed
Conversation
alexmwu
requested changes
Apr 9, 2025
| exitBootSvcDigest := hasher.Sum(nil) | ||
|
|
||
| var efiAppStates []*pb.EfiApp | ||
| var efiAppEvents []tcg.Event |
Collaborator
There was a problem hiding this comment.
Why are we returning these events?
Collaborator
This already exists. This PR only does 2.
I'm not sure we need to validate this action unless we plan on extracting the boot variable option. The Calling EFI App event is sufficient. |
Collaborator
Author
|
Talked offline, this PR is unnecessary for now unless we plan to extract the boot variable option. Closing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following two things:
<Boot####> Option” in PCR4 conforming to the TCG PC Client Platform Firmware Profile Specification.