Extract EFIBootServicesDriverEvents and populate them into FirmwareLogState#18
Merged
yawangwang merged 1 commit intogoogle:mainfrom Apr 9, 2025
Merged
Conversation
yawangwang
changed the title
alexmwu
requested changes
Apr 7, 2025
alexmwu
requested changes
Apr 7, 2025
yawangwang
force-pushed
the
extract_EFIBootServicesDriver
branch
from
5c9ce46 to
a31e3b5
Compare
yawangwang
changed the title
alexmwu
requested changes
Apr 9, 2025
Collaborator
alexmwu
left a comment
alexmwu
left a comment
There was a problem hiding this comment.
what about EV_EFI_RUNTIME_SERVICES_DRIVERs?
yawangwang
force-pushed
the
extract_EFIBootServicesDriver
branch
3 times, most recently
from
25a0e0b to
bc445cd
Compare
Collaborator
Author
According to the section 3.3.4.3 PCR[2]-UEFI Drivers and UEFI Applications https://trustedcomputinggroup.org/wp-content/uploads/TCG-PC-Client-Platform-Firmware-Profile-Version-1.06-Revision-52_pub-3.pdf, this event MUST be measured into PCR2 as well, so adding the extraction logics to |
alexmwu
approved these changes
Apr 9, 2025
alexmwu
reviewed
Apr 9, 2025
yawangwang
force-pushed
the
extract_EFIBootServicesDriver
branch
from
f1696de to
880ebab
Compare
alexmwu
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Host Attestation doc listed out all PCRs that need to be validated. One requirement is to validate each
efi_boot_services_driverentry against a list of golden measurements.This PR adds support to extract
efi_boot_services_driverandefi_runtime_services_driverand populate them intoFirmwareLogState.