Skip to content

fix(ads): count only unique account during mcc expansion #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndreyMarkinPPC merged 1 commit into from
Mar 11, 2026
Merged

fix(ads): count only unique account during mcc expansion #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libs/community/google/ads/garf/community/google/ads/report_fetcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,10 +198,10 @@ def expand_mcc(
raise GoogleAdsApiReportFetcherError(
f'No accounts found satisfying the follow query: {customer_ids_query}'
)
child_customer_ids = [
child_customer_ids = {
row[0] if isinstance(row, garf.core.report.GarfRow) else row
for row in child_customer_ids
]
}
span.set_attribute(
'accounts.child_accounts_conditioned', len(child_customer_ids)
)
Expand Down
Loading