Skip to content

Conversation

@simoncozens
Copy link
Collaborator

@simoncozens simoncozens commented Oct 15, 2025

Taken from the upstream repo https://github.com/notofonts/arabic at commit notofonts/arabic@1b2b7e5.

PR Checklist:

PR

  • The PR is in the Traffic Jam Board (Project > Traffic Jam Board)
  • It has the correct labels (upgrade, new font, specific language)
  • The PR is linked to the corresponding issue

QA

  • Fontspector checks are reviewed and failing checks are resolved in collaboration with the upstream font development team
  • Diffenator2 and 3 regression checks for revisions on all projects that are currently in production
  • The article has no typos, images are properly linked and correctly sized
  • OFL.txt contains the correct license URL (https://openfontlicense.org)

Specifics

  • primary_script definition in the METADATA.pb file for all projects that have a primary non-Latin based language support target
  • subsets definitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsets chinese-hongkong, chinese-simplified, chinese-traditional, korean, japanese.

Release

  • Designers bio info have to be present in the designer catalog (at least an issue should be opened for tracking this, if they are not)
  • Check designers order in metadata.pb, since the first one of the list appears as “principal designer”
  • Social media content draft for all new commissioned projects in the Drive directory and Social Media tracker spreadsheet, communicate with the repository Maintainer so that they can push this content to the Social Media tracker spreadsheet
  • minisite_url definition in the METADATA.pb file for commissioned projects
  • tags are added for NEW FONTS

@github-actions
Copy link
Contributor

FontSpector report

fontspector version: 1.5.1

Check results

[1] ofl/notosansarabic/DESCRIPTION.en_us.html
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
[16] ofl/notosansarabic/NotoSansArabic[wdth,wght].ttf
⚠️ WARN Check if each glyph has the recommended amount of contours. (contour_count)
  • ⚠️ WARN This check inspects the glyph outlines and detects the total number of contours in each of them. The expected values are
    inferred from the typical amounts of contours observed in a
    large collection of reference font families. The divergences
    listed below may simply indicate a significantly different
    design on some of your glyphs. On the other hand, some of these
    may flag actual bugs in the font such as glyphs mapped to an
    incorrect codepoint. Please consider reviewing the design and
    codepoint assignment of these to make sure they are correct.

    The following glyphs do not have the recommended number of contours:

  • uni0621 (U+FE80): found 2, expected one of: {1}
  • uni066E (U+066E): found 2, expected one of: {64, 1}
  • uni0635 (U+FEB9): found 1, expected one of: {2}
  • uni0635.init (U+FEBB): found 1, expected one of: {2, 96, 3}
  • uni0639 (U+FEC9): found 2, expected one of: {1}
  • uni08AC.fina (unencoded): found 4, expected one of: {3}
  • uni0645.init (U+FEE3): found 1, expected one of: {56, 2, 3}
  • uni0648 (U+FEED): found 1, expected one of: {2}
  • uni0667 (U+0667): found 2, expected one of: {1, 72}
    ... and 121 others [code: contour-count]
⚠️ WARN Detect any interpolation issues in the font. (interpolation_issues)
  • ⚠️ WARN Glyph uni06DE has interpolation issues:
  • Contour order mismatch: [0, 1, 2, 3, 4, 5] in default vs [0, 3, 2, 1, 4, 5] in wght=100
  • Contour 1 becomes underweight in wght=100 compared to default
  • Contour 3 becomes underweight in wght=100 compared to default [code: glyph]
⚠️ WARN Ensure indic fonts have the Indian Rupee Sign glyph. (rupee)
  • ⚠️ WARN Font is missing the Indian Rupee Sign glyph. Please add a glyph for Indian Rupee Sign (₹) at codepoint U+20B9. [code: missing-rupee]
⚠️ WARN Check font contains no unreachable glyphs (unreachable_glyphs)
  • ⚠️ WARN The following glyphs could not be reached by codepoint or substitution rules:
  • uni06BA.medi
  • uni06BA.init
  • uni06F7.mark [code: unreachable-glyphs]
⚠️ WARN Glyph names are all valid? (valid_glyphnames)
  • ⚠️ WARN The following glyph names are too long: "twodotshorizontalcenter_tahabovear, twodotshorizontalbelow_tahabovear, twodotshorizontalabove_tahabovear, twodotshorizontalabovear.diagonal" [code: legacy-long-names]
⚠️ WARN Shapes languages in all GF glyphsets. (googlefonts/glyphsets/shape_languages)
  • ⚠️ WARN Warning language shaping:
Message Languages
Auxiliary orthography codepoints: * cs_Latn (Czech)
The following auxiliary characters are missing from the font: Ĕ * cy_Latn (Welsh)
The following auxiliary characters are missing from the font: Ĭ * es_Latn (Spanish)
The following auxiliary characters are missing from the font: Ŏ * hu_Latn (Hungarian)
The following auxiliary characters are missing from the font: Ō * pt_Latn (Portuguese)
The following auxiliary characters are missing from the font: Ŭ * sk_Latn (Slovak)
The following auxiliary characters are missing from the font: ĕ * tr_Latn (Turkish)
The following auxiliary characters are missing from the font: ĭ
The following auxiliary characters are missing from the font: ŏ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ŭ
Auxiliary orthography codepoints: * lt_Latn (Lithuanian)
The following auxiliary characters are missing from the font: Ẽ
The following auxiliary characters are missing from the font: Ĩ
The following auxiliary characters are missing from the font: Ũ
The following auxiliary characters are missing from the font: ẽ
The following auxiliary characters are missing from the font: ĩ
The following auxiliary characters are missing from the font: ũ
Auxiliary orthography codepoints: * nb_Latn (Norwegian Bokmål)
The following auxiliary characters are missing from the font: Ǎ
The following auxiliary characters are missing from the font: Ŋ
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: ǎ
The following auxiliary characters are missing from the font: ŋ
The following auxiliary characters are missing from the font: ŧ
Auxiliary orthography codepoints: * fi_Latn (Finnish)
The following auxiliary characters are missing from the font: Ǧ
The following auxiliary characters are missing from the font: Ǥ
The following auxiliary characters are missing from the font: Ȟ
The following auxiliary characters are missing from the font: Ǩ
The following auxiliary characters are missing from the font: Ŋ
The following auxiliary characters are missing from the font: Ŝ
The following auxiliary characters are missing from the font: Ţ
The following auxiliary characters are missing from the font: Ŧ
The following auxiliary characters are missing from the font: Ʒ
The following auxiliary characters are missing from the font: Ǯ
The following auxiliary characters are missing from the font: ǧ
The following auxiliary characters are missing from the font: ǥ
The following auxiliary characters are missing from the font: ȟ
The following auxiliary characters are missing from the font: ǩ
The following auxiliary characters are missing from the font: ŋ
The following auxiliary characters are missing from the font: ŝ
The following auxiliary characters are missing from the font: ţ
The following auxiliary characters are missing from the font: ŧ
The following auxiliary characters are missing from the font: ʒ
The following auxiliary characters are missing from the font: ǯ
Auxiliary orthography codepoints: * ro_Latn (Romanian)
The following auxiliary characters are missing from the font: Ţ
The following auxiliary characters are missing from the font: ţ
Auxiliary orthography codepoints: * ca_Latn (Catalan)
The following auxiliary characters are missing from the font: Ĕ
The following auxiliary characters are missing from the font: Ĭ
The following auxiliary characters are missing from the font: Ŀ
The following auxiliary characters are missing from the font: Ŏ
The following auxiliary characters are missing from the font: Ō
The following auxiliary characters are missing from the font: Ŭ
The following auxiliary characters are missing from the font: ĕ
The following auxiliary characters are missing from the font: ĭ
The following auxiliary characters are missing from the font: ŀ
The following auxiliary characters are missing from the font: ŏ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ŭ
Auxiliary orthography codepoints: * fr_Latn (French)
The following auxiliary characters are missing from the font: Ǔ
The following auxiliary characters are missing from the font: ſ
The following auxiliary characters are missing from the font: ǔ
Auxiliary orthography codepoints: * da_Latn (Danish)
The following auxiliary characters are missing from the font: Ǿ
The following auxiliary characters are missing from the font: ǿ
Auxiliary orthography codepoints: * lv_Latn (Latvian)
The following auxiliary characters are missing from the font: Ō
The following auxiliary characters are missing from the font: Ŗ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ŗ
Auxiliary orthography codepoints: * nl_Latn (Dutch)
The following auxiliary characters are missing from the font: IJ
The following auxiliary characters are missing from the font: ij
Auxiliary orthography codepoints: * en_Latn (English)
The following auxiliary characters are missing from the font: Ĕ
The following auxiliary characters are missing from the font: Ĭ
The following auxiliary characters are missing from the font: Ŏ
The following auxiliary characters are missing from the font: Ō
The following auxiliary characters are missing from the font: Ŭ
The following auxiliary characters are missing from the font: ĕ
The following auxiliary characters are missing from the font: ĭ
The following auxiliary characters are missing from the font: ŏ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ŭ
The following auxiliary characters are missing from the font: ʻ
Auxiliary orthography codepoints: * de_Latn (German)
The following auxiliary characters are missing from the font: Ĕ
The following auxiliary characters are missing from the font: Ĭ
The following auxiliary characters are missing from the font: Ŏ
The following auxiliary characters are missing from the font: Ō
The following auxiliary characters are missing from the font: Ŭ
The following auxiliary characters are missing from the font: ĕ
The following auxiliary characters are missing from the font: ĭ
The following auxiliary characters are missing from the font: ŏ
The following auxiliary characters are missing from the font: ō
The following auxiliary characters are missing from the font: ſ
The following auxiliary characters are missing from the font: ŭ
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
  • ⚠️ WARN The following separator glyphs are missing:
  • U+2028
  • U+2029 [code: missing-separator-glyphs]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that replace the dot. (soft_dotted)
  • ⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
  • į̄

  • į́

  • į̃

  • į̂

  • į̀

  • į̌The dot of soft dotted characters should disappear in other cases, for example:

  • į̨̄

  • į̨̆

  • į̨́

  • į̨̃

  • į̨̈

  • į̨̋

  • į̨̂

  • į̨̀

  • į̨̇
    ... and 29 others [code: soft-dotted]

⚠️ WARN Check there are no overlapping path segments (overlapping_path_segments)
  • ⚠️ WARN The following glyphs have overlapping path segments:
  • uni06CD (U+06CD): Line(Line { p0: (72.0, 176.0), p1: (144.0, 148.0) }) has the same coordinates as a previous segment.
  • uniFEF5 (U+FEF5): Line(Line { p0: (398.0, 334.0), p1: (356.0, 269.0) }) has the same coordinates as a previous segment.
  • uniFEF7 (U+FEF7): Line(Line { p0: (398.0, 334.0), p1: (356.0, 269.0) }) has the same coordinates as a previous segment.
  • uniFEF9 (U+FEF9): Line(Line { p0: (398.0, 334.0), p1: (356.0, 269.0) }) has the same coordinates as a previous segment.
  • uniFEFB (U+FEFB): Line(Line { p0: (398.0, 334.0), p1: (356.0, 269.0) }) has the same coordinates as a previous segment. [code: overlapping-path-segments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
  • ⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
  • ℹ️ INFO The family name "Noto Sans Arabic" seems to be already in use.
    Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
  • ℹ️ INFO Hinting filesize impact:
NotoSansArabic[wdth,wght].ttf
Dehinted Size 790048
Hinted Size 790072
Increase 24
Change 0.0 %
ℹ️ INFO Font contains all required tables? (required_tables)
  • ℹ️ INFO This font contains the following optional tables:

    loca
    prep
    GPOS
    GSUB
    gasp [code: optional-tables]

ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
  • ℹ️ INFO These are the ppm ranges declared on the gasp table:

| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |

- Use smoothing along multiple axes with ClearType®
[code: ranges]
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
  • ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 2.013 [code: version-not-detected]
[1] ofl/notosansarabic/METADATA.pb
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
  • ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[5] ofl/notosansarabic
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
  • 🔥 FAIL We detected support for the Yapese language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
  • ʼ (U+02BC) [code: bad-sample-text]
  • 🔥 FAIL We detected support for the Yucateco language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
  • ʼ (U+02BC) [code: bad-sample-text]
⚠️ WARN Validate size, and resolution of article images, and ensure article page has minimum length and includes visual assets. (googlefonts/article/images)
  • ⚠️ WARN Article page lacks visual assets. [code: missing-visual-asset]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
  • ⚠️ WARN ofl/notosansarabic/NotoSansArabic[wdth,wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
  • U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
  • U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
  • U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
  • U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
  • U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
  • U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
  • U+030C COMBINING CARON: try adding one of: cherokee, tai-le
  • U+200F RIGHT-TO-LEFT MARK: try adding one of: nko, phags-pa, hebrew, thaana, syriac
  • U+202F NARROW NO-BREAK SPACE: try adding one of: mongolian, phags-pa, yi

Or you can add the above codepoints to one of the subsets supported by the font: arabic, latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]

ℹ️ INFO METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
  • ℹ️ INFO The subset 'latin-ext' is listed in production metadata, but only 0.09% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]

  • ℹ️ INFO The subset 'symbols' is listed in production metadata, but only 0.02% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]

  • ℹ️ INFO The subset 'math' is listed in production metadata, but only 0.04% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]

ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
  • ℹ️ INFO None of the fonts lack a STAT table.

    And these are the most common STAT axis orderings:
    wght-wdth: 1 [code: summary]

[2] ofl/notosansarabic/article/ARTICLE.en_us.html
🔥 FAIL Does DESCRIPTION file contain broken links? (googlefonts/description/broken_links)
  • 🔥 FAIL The following links are broken:
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
  • 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]

Summary

🔥 FAIL ⚠️ WARN ℹ️ INFO ✅ PASS ⏩ SKIP
5 12 11 150 32
2% 6% 5% 72% 15%

@simoncozens
Copy link
Collaborator Author

I manually checked the interpolation issue, it's a false positive.

@emmamarichal emmamarichal added II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts -- Needs Upstream Resolution Upstream fix required before moving forward labels Oct 16, 2025
@emmamarichal
Copy link
Collaborator

@simoncozens same issue than in Kufi Arabic with the slider and weight axis:

Screen.Recording.2025-10-16.at.15.22.24.mov

@simoncozens
Copy link
Collaborator Author

Something has gone wrong with the subset merger again:

INFO:gftools.subsetmerger:Adding master NotoSans-Regular.ufo for location {'wght': 700.0, 'wdth': 100.0}

@emmamarichal
Copy link
Collaborator

@simoncozens ok! I hope it's not to difficult to solve. Don't hesitate to ping me once it's updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-- Needs Upstream Resolution Upstream fix required before moving forward I Font Upgrade II Arabic / Hebrew / Semitic / RTL Middle-east and afro-asian RTL scripts

Projects

Status: PR GF

Development

Successfully merging this pull request may close these issues.

2 participants