-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Noto Sans Arabic: Version 2.013 added #9919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Taken from the upstream repo https://github.com/notofonts/arabic at commit notofonts/arabic@1b2b7e5.
FontSpector reportfontspector version: 1.5.1 Check results[1] ofl/notosansarabic/DESCRIPTION.en_us.html🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
[16] ofl/notosansarabic/NotoSansArabic[wdth,wght].ttf
|
| Message | Languages |
|---|---|
| Auxiliary orthography codepoints: | * cs_Latn (Czech) |
| The following auxiliary characters are missing from the font: Ĕ | * cy_Latn (Welsh) |
| The following auxiliary characters are missing from the font: Ĭ | * es_Latn (Spanish) |
| The following auxiliary characters are missing from the font: Ŏ | * hu_Latn (Hungarian) |
| The following auxiliary characters are missing from the font: Ō | * pt_Latn (Portuguese) |
| The following auxiliary characters are missing from the font: Ŭ | * sk_Latn (Slovak) |
| The following auxiliary characters are missing from the font: ĕ | * tr_Latn (Turkish) |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ŭ | |
| Auxiliary orthography codepoints: | * lt_Latn (Lithuanian) |
| The following auxiliary characters are missing from the font: Ẽ | |
| The following auxiliary characters are missing from the font: Ĩ | |
| The following auxiliary characters are missing from the font: Ũ | |
| The following auxiliary characters are missing from the font: ẽ | |
| The following auxiliary characters are missing from the font: ĩ | |
| The following auxiliary characters are missing from the font: ũ | |
| Auxiliary orthography codepoints: | * nb_Latn (Norwegian Bokmål) |
| The following auxiliary characters are missing from the font: Ǎ | |
| The following auxiliary characters are missing from the font: Ŋ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: ǎ | |
| The following auxiliary characters are missing from the font: ŋ | |
| The following auxiliary characters are missing from the font: ŧ | |
| Auxiliary orthography codepoints: | * fi_Latn (Finnish) |
| The following auxiliary characters are missing from the font: Ǧ | |
| The following auxiliary characters are missing from the font: Ǥ | |
| The following auxiliary characters are missing from the font: Ȟ | |
| The following auxiliary characters are missing from the font: Ǩ | |
| The following auxiliary characters are missing from the font: Ŋ | |
| The following auxiliary characters are missing from the font: Ŝ | |
| The following auxiliary characters are missing from the font: Ţ | |
| The following auxiliary characters are missing from the font: Ŧ | |
| The following auxiliary characters are missing from the font: Ʒ | |
| The following auxiliary characters are missing from the font: Ǯ | |
| The following auxiliary characters are missing from the font: ǧ | |
| The following auxiliary characters are missing from the font: ǥ | |
| The following auxiliary characters are missing from the font: ȟ | |
| The following auxiliary characters are missing from the font: ǩ | |
| The following auxiliary characters are missing from the font: ŋ | |
| The following auxiliary characters are missing from the font: ŝ | |
| The following auxiliary characters are missing from the font: ţ | |
| The following auxiliary characters are missing from the font: ŧ | |
| The following auxiliary characters are missing from the font: ʒ | |
| The following auxiliary characters are missing from the font: ǯ | |
| Auxiliary orthography codepoints: | * ro_Latn (Romanian) |
| The following auxiliary characters are missing from the font: Ţ | |
| The following auxiliary characters are missing from the font: ţ | |
| Auxiliary orthography codepoints: | * ca_Latn (Catalan) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŀ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: Ō | |
| The following auxiliary characters are missing from the font: Ŭ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŀ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ŭ | |
| Auxiliary orthography codepoints: | * fr_Latn (French) |
| The following auxiliary characters are missing from the font: Ǔ | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ǔ | |
| Auxiliary orthography codepoints: | * da_Latn (Danish) |
| The following auxiliary characters are missing from the font: Ǿ | |
| The following auxiliary characters are missing from the font: ǿ | |
| Auxiliary orthography codepoints: | * lv_Latn (Latvian) |
| The following auxiliary characters are missing from the font: Ō | |
| The following auxiliary characters are missing from the font: Ŗ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ŗ | |
| Auxiliary orthography codepoints: | * nl_Latn (Dutch) |
| The following auxiliary characters are missing from the font: IJ | |
| The following auxiliary characters are missing from the font: ij | |
| Auxiliary orthography codepoints: | * en_Latn (English) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: Ō | |
| The following auxiliary characters are missing from the font: Ŭ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ŭ | |
| The following auxiliary characters are missing from the font: ʻ | |
| Auxiliary orthography codepoints: | * de_Latn (German) |
| The following auxiliary characters are missing from the font: Ĕ | |
| The following auxiliary characters are missing from the font: Ĭ | |
| The following auxiliary characters are missing from the font: Ŏ | |
| The following auxiliary characters are missing from the font: Ō | |
| The following auxiliary characters are missing from the font: Ŭ | |
| The following auxiliary characters are missing from the font: ĕ | |
| The following auxiliary characters are missing from the font: ĭ | |
| The following auxiliary characters are missing from the font: ŏ | |
| The following auxiliary characters are missing from the font: ō | |
| The following auxiliary characters are missing from the font: ſ | |
| The following auxiliary characters are missing from the font: ŭ |
⚠️ WARN Font has correct separator glyphs? (googlefonts/separator_glyphs)
⚠️ WARN The following separator glyphs are missing:
- U+2028
- U+2029 [code: missing-separator-glyphs]
⚠️ WARN Ensure soft_dotted characters lose their dot when combined with marks that
replace the dot. (soft_dotted)
⚠️ WARN The dot of soft dotted characters used in orthographies must disappear in the following strings:
-
į̄
-
į́
-
į̃
-
į̂
-
į̀
-
į̌The dot of soft dotted characters should disappear in other cases, for example:
-
į̨̄
-
į̨̆
-
į̨́
-
į̨̃
-
į̨̈
-
į̨̋
-
į̨̂
-
į̨̀
-
į̨̇
... and 29 others [code: soft-dotted]
⚠️ WARN Check there are no overlapping path segments (overlapping_path_segments)
⚠️ WARN The following glyphs have overlapping path segments:
- uni06CD (U+06CD): Line(Line { p0: (72.0, 176.0), p1: (144.0, 148.0) }) has the same coordinates as a previous segment.
- uniFEF5 (U+FEF5): Line(Line { p0: (398.0, 334.0), p1: (356.0, 269.0) }) has the same coordinates as a previous segment.
- uniFEF7 (U+FEF7): Line(Line { p0: (398.0, 334.0), p1: (356.0, 269.0) }) has the same coordinates as a previous segment.
- uniFEF9 (U+FEF9): Line(Line { p0: (398.0, 334.0), p1: (356.0, 269.0) }) has the same coordinates as a previous segment.
- uniFEFB (U+FEFB): Line(Line { p0: (398.0, 334.0), p1: (356.0, 269.0) }) has the same coordinates as a previous segment. [code: overlapping-path-segments]
⚠️ WARN Ensure fonts have ScriptLangTags declared on the 'meta' table. (googlefonts/meta/script_lang_tags)
⚠️ WARN This font file does not have a 'meta' table. [code: lacks-meta-table]
ℹ️ INFO Checking OS/2 fsSelection value. (opentype/xavgcharwidth)
- ℹ️ INFO OS/2 xAvgCharWidth is 855 but it should be 854 which corresponds to the average of the widths of all glyphs in the font. These are similar values, which may be a symptom of the slightly different calculation of the xAvgCharWidth value in font editors. There's further discussion on this at com.google.fonts/test/034: xAvgCharWidth bakery vs glyphs vs font val fonttools/fontbakery#1622 [code: xAvgCharWidth-close]
ℹ️ INFO Familyname must be unique according to namecheck.fontdata.com (fontdata_namecheck)
- ℹ️ INFO The family name "Noto Sans Arabic" seems to be already in use.
Please visit http://namecheck.fontdata.com/ for more info. [code: name-collision]
ℹ️ INFO Show hinting filesize impact. (hinting_impact)
- ℹ️ INFO Hinting filesize impact:
| NotoSansArabic[wdth,wght].ttf | |
|---|---|
| Dehinted Size | 790048 |
| Hinted Size | 790072 |
| Increase | 24 |
| Change | 0.0 % |
ℹ️ INFO Font contains all required tables? (required_tables)
-
ℹ️ INFO This font contains the following optional tables:
loca
prep
GPOS
GSUB
gasp [code: optional-tables]
ℹ️ INFO Is the Grid-fitting and Scan-conversion Procedure ('gasp') table set to optimize rendering? (googlefonts/gasp)
- ℹ️ INFO These are the ppm ranges declared on the gasp table:
| PPM <= 65535 | - Use grid-fitting |
| | - Use grayscale rendering |
| | - Use gridfitting with ClearType symmetric smoothing |
| - Use smoothing along multiple axes with ClearType® | |
|---|---|
| [code: ranges] |
ℹ️ INFO Font has old ttfautohint applied? (googlefonts/old_ttfautohint)
- ℹ️ INFO Could not detect which version of ttfautohint was used in this font. It is typically specified as a comment in the font version entries of the 'name' table. Such font version strings are currently: Version 2.013 [code: version-not-detected]
[1] ofl/notosansarabic/METADATA.pb
ℹ️ INFO Check METADATA.pb parses correctly (googlefonts/metadata/validate)
- ℹ️ INFO Please consider adding a family.minisite_url entry. [code: lacks-minisite-url]
[5] ofl/notosansarabic
🔥 FAIL Tofu should not be shown in sample texts. (googlefonts/tofu)
- 🔥 FAIL We detected support for the Yapese language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ʼ (U+02BC) [code: bad-sample-text]
- 🔥 FAIL We detected support for the Yucateco language because the font contained all the base exemplars for the language, but the font is missing the following codepoints needed to render the specimen 16 sample text (This suggests there's something wrong with the sample text):
- ʼ (U+02BC) [code: bad-sample-text]
⚠️ WARN Validate size, and resolution of article images,
and ensure article page has minimum length and includes visual assets. (googlefonts/article/images)
⚠️ WARN Article page lacks visual assets. [code: missing-visual-asset]
⚠️ WARN Check for codepoints not covered by METADATA subsets. (googlefonts/metadata/unreachable_subsetting)
⚠️ WARN ofl/notosansarabic/NotoSansArabic[wdth,wght].ttf: The following codepoints supported by the font are not covered by any subsets defined in the font's metadata file, and will never be served. You can solve this by either manually adding additional subset declarations to METADATA.pb, or by editing the glyphset definitions.
- U+02D8 BREVE: try adding one of: yi, canadian-aboriginal
- U+02D9 DOT ABOVE: try adding one of: yi, canadian-aboriginal
- U+02DB OGONEK: try adding one of: canadian-aboriginal, yi
- U+0306 COMBINING BREVE: try adding one of: old-permic, tifinagh
- U+030A COMBINING RING ABOVE: try adding one of: duployan, syriac
- U+030B COMBINING DOUBLE ACUTE ACCENT: try adding one of: cherokee, osage
- U+030C COMBINING CARON: try adding one of: cherokee, tai-le
- U+200F RIGHT-TO-LEFT MARK: try adding one of: nko, phags-pa, hebrew, thaana, syriac
- U+202F NARROW NO-BREAK SPACE: try adding one of: mongolian, phags-pa, yi
Or you can add the above codepoints to one of the subsets supported by the font: arabic, latin, latin-ext, math, menu, symbols [code: unreachable-subsetting]
ℹ️ INFO METADATA.pb subsets are correct? (googlefonts/metadata/subsets_correct)
-
ℹ️ INFO The subset 'latin-ext' is listed in production metadata, but only 0.09% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'symbols' is listed in production metadata, but only 0.02% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
-
ℹ️ INFO The subset 'math' is listed in production metadata, but only 0.04% of its glyphs are supported by this font file. We can't remove it, however, since that would cause a regression in production. [code: unsupported-production-subset]
ℹ️ INFO Check axis ordering on the STAT table. (googlefonts/STAT/axis_order)
-
ℹ️ INFO None of the fonts lack a STAT table.
And these are the most common STAT axis orderings:
wght-wdth: 1 [code: summary]
[2] ofl/notosansarabic/article/ARTICLE.en_us.html
🔥 FAIL Does DESCRIPTION file contain broken links? (googlefonts/description/broken_links)
- 🔥 FAIL The following links are broken:
- https://en.wiktionary.org/wiki/Category:Arabic_script (status code: 403 Forbidden)
- https://scriptsource.org/scr/Arab (status code: 403 Forbidden)
- https://en.wikipedia.org/wiki/ISO_15924:Arab (status code: 403 Forbidden) [code: broken-links]
🔥 FAIL Does DESCRIPTION file contain a upstream Git repo URL? (googlefonts/description/git_url)
- 🔥 FAIL Please host your font project on a public Git repo (such as GitHub or GitLab) and place a link in the DESCRIPTION.en_us.html file. [code: lacks-git-url]
Summary
| 🔥 FAIL | ℹ️ INFO | ✅ PASS | ⏩ SKIP | |
|---|---|---|---|---|
| 5 | 12 | 11 | 150 | 32 |
| 2% | 6% | 5% | 72% | 15% |
|
I manually checked the interpolation issue, it's a false positive. |
|
@simoncozens same issue than in Kufi Arabic with the slider and weight axis: Screen.Recording.2025-10-16.at.15.22.24.mov |
|
Something has gone wrong with the subset merger again:
|
|
@simoncozens ok! I hope it's not to difficult to solve. Don't hesitate to ping me once it's updated :) |
Taken from the upstream repo https://github.com/notofonts/arabic at commit notofonts/arabic@1b2b7e5.
PR Checklist:
PR
QA
Specifics
primary_scriptdefinition in the METADATA.pb file for all projects that have a primary non-Latin based language support targetsubsetsdefinitions in the METADATA.pb reflect the actual subsets and languages present in the font files (in alphabetic order). For CJK fonts, only include one of the following subsetschinese-hongkong,chinese-simplified,chinese-traditional,korean,japanese.Release
minisite_urldefinition in the METADATA.pb file for commissioned projectstagsare added for NEW FONTS