Skip to content

log4j2: Use setContextData not setContextMap #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
paladox wants to merge 2 commits into
base: master
Choose a base branch
from
Open

log4j2: Use setContextData not setContextMap #156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
368417b
log4j2: Use setContextData not setContextMap
paladox Apr 13, 2020
d376ac2
Update Log4j2SimpleLogEvent.java
paladox Apr 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions log4j2/src/main/java/com/google/common/flogger/backend/log4j2/Log4j2SimpleLogEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
import org.apache.logging.log4j.core.impl.Log4jLogEvent;
import org.apache.logging.log4j.core.util.Throwables;
import org.apache.logging.log4j.message.SimpleMessage;
import org.apache.logging.log4j.util.SortedArrayStringMap;

/** Class that represents a log entry that can be written to log4j2. */
final class Log4j2SimpleLogEvent implements SimpleLogHandler {
Expand Down Expand Up @@ -84,9 +85,9 @@ LogEvent asLoggingEvent() {
// are written from the current thread.
//
// Example:
// MDC.put("user.id", userId);
// ThreadContext.put("user.id", userId);
// // do business logic that triggers logs
// MDC.clear();
// ThreadContext.clear();
//
// By using '%X{key}' in the ConversionPattern of an appender this data can be included in the
// logs.
Expand All @@ -112,7 +113,7 @@ LogEvent asLoggingEvent() {
.setThrown(thrown != null ? Throwables.getRootCause(thrown) : null)
.setIncludeLocation(true)
.setSource(getLocationInfo())
.setContextMap(mdcProperties)
.setContextData(new SortedArrayStringMap(mdcProperties))
.build();
}

Expand Down