Skip to content

Change clients to placement in impls.py documentation. #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 16, 2025
Merged

Change clients to placement in impls.py documentation. #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions drjax/_src/impls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def _placement_axis_in_mesh(
mesh: jax.sharding.Mesh | jax.sharding.AbstractMesh | None,
placement: str,
) -> bool:
"""Checks if a clients axis is present in the mesh."""
"""Checks if a placement axis is present in the mesh."""
if mesh is None:
return False
placement_is_in_mesh = placement in mesh.axis_names
Expand Down Expand Up @@ -146,7 +146,7 @@ def broadcast_to_placement(
if _placement_axis_in_mesh(mesh, placement):
pspec = P(placement, *([P.UNCONSTRAINED] * len(arg.shape)))
else:
# Without a clients axis in the mesh, we simply explicitly tell the
# Without a placement axis in the mesh, we simply explicitly tell the
# compiler that there are no constraints on this tensor. This will leave
# the choices in the hands of the compiler.
pspec = P(*([P.UNCONSTRAINED] * (len(arg.shape) + 1)))
Expand Down
Loading