Allow users to specify placement names and sizes directly with kwargs of drjax.program.#16
Merged
copybara-service[bot] merged 1 commit intomainfrom Apr 24, 2025
Merged
Conversation
… of `drjax.program`.
Previously users could only write `drjax.program({'foo': 5})` (optionally naming the argument `placements`).
Now users can directly write the placement with:
`drjax.program(foo=5)`.
Note that the placement name `placements` is reserved, i.e. `drjax.proram(placesment=5)` is not allowed.
PiperOrigin-RevId: 750988233
copybara-service
bot
force-pushed
the
cl/750713353
branch
from
d82f3a7 to
051c7e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow users to specify placement names and sizes directly with kwargs of
drjax.program.Previously users could only write
drjax.program({'foo': 5})(optionally naming the argumentplacements).Now users can directly write the placement with:
drjax.program(foo=5).Note that the placement name
placementsis reserved, i.e.drjax.proram(placesment=5)is not allowed.