Add SSL_set1_groups to NativeCrypto. #1443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tholenst
reviewed
Dec 10, 2025
| } | ||
|
|
||
| @Test | ||
| public void setCurveList_unsupportedCurvesOrInvalid_throwsIllegalArgumentException() |
There was a problem hiding this comment.
I'm not sure this is a good test. Does this mean that if BoringSSL adds any of those this test fails? Or should they never be added?
In principle, you shouldn't test someone elses API which could change (though with BoringSSL and Conscrypt this anyhow might be a special case)
Collaborator
Author
There was a problem hiding this comment.
You are right. I've removed the "unsupported" test cases, and only left the "invalid" ones.
tholenst
reviewed
Dec 10, 2025
tholenst
left a comment
tholenst
left a comment
There was a problem hiding this comment.
As you suggested offline, consider to use SSL_set1_groups instead.
SSL_set1_groups is simpler.
juergw
changed the title
Collaborator
Author
Done. PTAL. |
tholenst
reviewed
Dec 11, 2025
int and jint may not have the same size, so doing this makes sure that it always works.
tholenst
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be needed to add support for SSLParams.setNamedGroups,
which is needed to support Post-quantum algorithms, see https://openjdk.org/jeps/527.