Accept foreign ML-DSA keys for sign and verify. #1442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we use OpenSSLKey.fromPublicKey(publicKey). But that doesn't work for ML-DSA, because it used an old parse function that doesn't support ML-DSA. It is better to use engineTranslateKey.
juergw
changed the title
miguelaranda0
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenSslSignatureMlDsa currently uses OpenSSLKey.fromPrivateKey and OpenSSLKey.fromPublicKey, which do this conversion for other key types. But it uses the functions NativeCrypto.EVP_parse_private_key and NativeCrypto.EVP_parse_public_key, which do not support ML-DSA. So we can't use them. Instead, we use the key factory to translate the key for us.