Remove 3DES from conscrypt #1267
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class is created by codegen in the gmscore version of conscrypt and so we need the logging path to go through it in order for it to be replaced in gmscore
This class is created by codegen in the gmscore version of conscrypt and so we need the logging path to go through it in order for it to be replaced in gmscore
Bug: 357870429 Ignore-AOSP-First: Security fix (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:0c47caf05209b8adadb6c71689b29b6608680329) (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:7ffe97a8034fc98d4f91e0a24793d5f99200523f) Merged-In: Ic61848e0455a48ea4b39cd67ef78280aa403beba Change-Id: Ic61848e0455a48ea4b39cd67ef78280aa403beba
Member
|
Sorry for the "Merge branch 'master' into upload2. I thought that this button would rebase your change on top of master but it did the opposite. Could you update your branch so that only the commit "Remove 3DES from conscrypt" appears in the pull request? Thanks |
Note: this deprecates those protocols, but please let me know if I should revert that part of the change. This reverts commit 5ae7b5c2f272365d13c9ff3ba0c7a682375dc1d8. Reason for revert: fixed the failures by checking that API levels are not higher than a 100, and bumped API level check to 36 because I noticed that this version of using reflection is more resilient than the previous one. Change-Id: I42fcb922e046072eea0fa5aee07c513233d2b1e9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.