Skip to content

Add example for configuring macros with cel::CompilerBuilder. #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 11, 2025
Merged

Add example for configuring macros with cel::CompilerBuilder. #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions compiler/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ cc_test(
"//testutil:baseline_tests",
"@com_google_absl//absl/status",
"@com_google_absl//absl/status:status_matchers",
"@com_google_absl//absl/strings",
"@com_google_protobuf//:protobuf",
],
)
Expand Down
39 changes: 39 additions & 0 deletions compiler/compiler_factory_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

#include "absl/status/status.h"
#include "absl/status/status_matchers.h"
#include "absl/strings/match.h"
#include "checker/optional.h"
#include "checker/standard_library.h"
#include "checker/type_check_issue.h"
Expand All @@ -42,6 +43,7 @@ using ::cel::test::FormatBaselineAst;
using ::testing::Contains;
using ::testing::HasSubstr;
using ::testing::Property;
using ::testing::Truly;

TEST(CompilerFactoryTest, Works) {
ASSERT_OK_AND_ASSIGN(
Expand Down Expand Up @@ -162,6 +164,43 @@ TEST(CompilerFactoryTest, ParserOptions) {
ASSERT_THAT(compiler->Compile("a.?b.orValue('foo')"), IsOk());
}

TEST(CompilerFactoryTest, DisableStandarMacros) {
CompilerOptions options;
options.parser_options.disable_standard_macros = true;

ASSERT_OK_AND_ASSIGN(
auto builder,
NewCompilerBuilder(cel::internal::GetSharedTestingDescriptorPool(),
options));

ASSERT_THAT(builder->AddLibrary(StandardCheckerLibrary()), IsOk());
ASSERT_THAT(builder->GetParserBuilder().AddMacro(cel::ExistsMacro()), IsOk());

// a: map(dyn, dyn)
ASSERT_THAT(builder->GetCheckerBuilder().AddVariable(
MakeVariableDecl("a", MapType())),
IsOk());

ASSERT_OK_AND_ASSIGN(auto compiler, std::move(*builder).Build());

ASSERT_OK_AND_ASSIGN(ValidationResult result, compiler->Compile("a.b"));

EXPECT_TRUE(result.IsValid());

// The has macro is disabled, so looks like a function call.
ASSERT_OK_AND_ASSIGN(result, compiler->Compile("has(a.b)"));

EXPECT_FALSE(result.IsValid());
EXPECT_THAT(result.GetIssues(),
Contains(Truly([](const TypeCheckIssue& issue) {
return absl::StrContains(issue.message(),
"undeclared reference to 'has'");
})));

ASSERT_OK_AND_ASSIGN(result, compiler->Compile("a.exists(x, x == 'foo')"));
EXPECT_TRUE(result.IsValid());
}

TEST(CompilerFactoryTest, FailsIfLibraryAddedTwice) {
ASSERT_OK_AND_ASSIGN(
auto builder,
Expand Down