elf: Only add SHF_ALLOC symbols to VM map #471
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only symbols in sections marked with `SHF_ALLOC` should be added to the VM map. This adds a check to filter non-`SHF_ALLOC` entries and fixes an issue where info related sections could have addresses that conflicted with `SHF_ALLOC` sections that actually affect the VM size. Fixes: google#469
Adds a test to make sure information sections that overlap with `SHF_ALLOC` sections are ignored for VM mappings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only symbols in sections marked with
SHF_ALLOCshould be added to theVM map. This adds a check to filter non-
SHF_ALLOCentries and fixes anissue where info related sections could have addresses that conflicted
with
SHF_ALLOCsections that actually affect the VM size.Fixes: #469