Fix segfault in ReadTopLevelDIE with malformed DWARF #461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `ReadCode` returns nullptr (e.g. due to a short DWARF compilation unit), `abbrev` becomes null. Passing this null pointer to `ReadAttributes` caused a segmentation fault. This patch adds a check to return early if `abbrev` is null. Fixes: google#401 Fixes: google#398
Adds a regression test that checks that missing DIEs are handled gracefully.
This was referenced Nov 26, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
ReadCodereturns nullptr (e.g. due to a short DWARF compilation unit),abbrevbecomes null. Passing this null pointer toReadAttributescaused a segmentation fault. This patch adds a check to return early ifabbrevis null.Fixes: #403
Fixes: #401
Fixes: #398