Fix: Handle DWARF5 address size mismatch #460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A malformed DWARF5 file with an address_size of 0 in the .debug_line header would cause an assertion failure. This happened in `LineInfoReader::SeekToOffset` when comparing against the compile unit address size. This change replaces the assertion with a THROW, allowing Bloaty to exit gracefully with a clear error message instead of crashing. A new lit test creates a minimal reproduction of the malformed DWARF to verify the fix. Fixes google#448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A malformed DWARF5 file with an address_size of 0 in the .debug_line header would cause an assertion failure. This happened in
LineInfoReader::SeekToOffsetwhen comparing against the compile unit address size.This change replaces the assertion with a THROW, allowing Bloaty to exit gracefully with a clear error message instead of crashing.
A new lit test creates a minimal reproduction of the malformed DWARF to verify the fix.
Fixes #448