Update darwin headers #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates third_party/darwin_xnu_macho headers to latest versions from Apple open source repositories: - mach-o headers from cctools (include/mach-o/) - mach headers from XNU (osfmk/mach/) Fixes google#438
fully reproducible. Usage: # To update headers to versions specified in METADATA: python3 update_headers.py # To regenerate patches after manual modifications: python3 generate_patches.py Current patches: - mach_machine.h.patch: Adds __has_include() guards and fallback typedefs - mach-o_loader.h.patch: Uses bundled header instead of system header Fixes google#438
Collaborator
|
Thanks! Taking a look at this today, I'm going to start with reproducing your changes locally. |
EricRahm
reviewed
Nov 19, 2025
EricRahm
approved these changes
Nov 19, 2025
Collaborator
EricRahm
left a comment
EricRahm
left a comment
There was a problem hiding this comment.
lgtm, thanks for taking the time to add detailed documentation including the upgrade scripts, this made reviewing much easier and will make future upgrades easier as well. Locally I reproduced the same set of changes using the update_headers.py script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes an update to the Darwin XNU/Mach-O headers, as well as scripts and docs to reproduce the changes and updates to the headers.