Fix errors found through valgrind/asan #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a use-after-free that was causing a memory corruption error. The filenames set would be created, written into, then copied into a vector of string_view. After the scope exit, the string_views were read and would have dangling references to the destroyed set.
Contributor
|
These changes look good to me. |
Contributor
Author
|
ping @snehasish - this seems like a low-risk patch |
snehasish
approved these changes
Jul 24, 2025
Collaborator
snehasish
left a comment
snehasish
left a comment
There was a problem hiding this comment.
lgtm, will merge after the CI run.
dc03-work
added a commit
to dc03-work/autofdo
that referenced
this pull request
Oct 9, 2025
This patch fixes a use-after-free that was causing a memory corruption error. The filenames set would be created, written into, then copied into a vector of string_view. After the scope exit, the string_views were read and would have dangling references to the destroyed set. Also fix uninitialized variable warnings from valgrind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch 1/2 fixes a use-after-free found using ASan. Patch 2/2 fixes various uninitialized variable warnings that were found using valgrind.