Mark some intrinsically Linux-specific targets. #2052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Databean
approved these changes
Jan 23, 2026
Some of these targets are intrinsically Linux specific or depend on Linux-specific functionality. They should be marked as such. We're not supplying alternative implementations here, but it makes sense to provide this information.
Databean
reviewed
Jan 23, 2026
Databean
reviewed
Jan 23, 2026
Comment on lines
+449
to
+451
| target_compatible_with = [ | ||
| "@platforms//os:linux", | ||
| ], |
Member
There was a problem hiding this comment.
AF_VSOCK is linux-specific, but SharedFD::VsockClient will actually use unix sockets when running with the vhost-user-vsock host process.
Collaborator
Author
There was a problem hiding this comment.
VsockServer is marked #ifdef __linux__ in shared_fd.cpp, though. Perhaps incorrectly so or over-eagerly so, but may still be good to keep this one marked as such?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of these targets are intrinsically Linux specific or depend on Linux-specific functionality. They should be marked as such. We're not supplying alternative implementations here, but it makes sense to provide this information.