refactor(vm): separate argument parsing and device creation#346
Merged
Lencerf merged 2 commits intogoogle:mainfrom Dec 26, 2025
Merged
refactor(vm): separate argument parsing and device creation#346Lencerf merged 2 commits intogoogle:mainfrom
Lencerf merged 2 commits intogoogle:mainfrom
Conversation
81494e5 to
59cb545
Compare
Pull Request Test Coverage Report for Build 20530326650Details
💛 - Coveralls |
59cb545 to
c3f9cb9
Compare
7240ce1 to
4faf70a
Compare
Introduce a unified VM config structure, let CLI focuse on argument parsing only, and move device creation into core crate. Signed-off-by: Changyuan Lyu <changyuanl@google.com>
Signed-off-by: Changyuan Lyu <changyuanl@google.com>
4faf70a to
d173570
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a unified VM config structure, let CLI focuse on argument
parsing only, and move device creation into core crate.