-
Notifications
You must be signed in to change notification settings - Fork 2.1k
chore: Reformatted the podcast-transcript-agent sample by ensuring black, isort, and flake8 pass #763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
||
| from .agent import podcast_episode_planner_agent | ||
|
|
||
| from .agent import podcast_episode_planner_agent # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this import be moved to where the import is actually used? (to avoid having to use noqa)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good comment for the sample owner. I don't want to make such changes though, since I am just applying formatters to the sample in this PR.
| from .agent import podcast_transcript_writer_agent | ||
|
|
||
|
|
||
| from .agent import podcast_transcript_writer_agent # noqa: F401 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
| inline_data=types.Blob( | ||
| mime_type="text/plain", data=file_content | ||
| ) | ||
| inline_data=types.Blob(mime_type="text/plain", data=file_content) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
black's recommendation is 88 chars per line. This line is 82 characters. So, it should be okay.
| assert ( | ||
| found_valid_transcript | ||
| ), "No final event found with valid transcript metadata" | ||
| assert found_valid_transcript, "No final event found with valid transcript metadata" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
length
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line is exactly 88 chars. When I ran black, it would have reformatted it automatically if this line was too long.
No description provided.