Skip to content

Conversation

@happyhuman
Copy link
Collaborator

No description provided.

@happyhuman happyhuman self-assigned this Dec 9, 2025
@mstyer-google mstyer-google self-assigned this Dec 10, 2025

from .agent import podcast_episode_planner_agent

from .agent import podcast_episode_planner_agent # noqa: F401
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this import be moved to where the import is actually used? (to avoid having to use noqa)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good comment for the sample owner. I don't want to make such changes though, since I am just applying formatters to the sample in this PR.

from .agent import podcast_transcript_writer_agent


from .agent import podcast_transcript_writer_agent # noqa: F401
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

inline_data=types.Blob(
mime_type="text/plain", data=file_content
)
inline_data=types.Blob(mime_type="text/plain", data=file_content)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

length

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

black's recommendation is 88 chars per line. This line is 82 characters. So, it should be okay.

assert (
found_valid_transcript
), "No final event found with valid transcript metadata"
assert found_valid_transcript, "No final event found with valid transcript metadata"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

length

Copy link
Collaborator Author

@happyhuman happyhuman Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is exactly 88 chars. When I ran black, it would have reformatted it automatically if this line was too long.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants