Fixed text-centering#24
Open
marcelthebridge wants to merge 1 commit intogoogle-developer-training:mainfrom
Open
Fixed text-centering#24marcelthebridge wants to merge 1 commit intogoogle-developer-training:mainfrom
marcelthebridge wants to merge 1 commit intogoogle-developer-training:mainfrom
Conversation
The solution code does in fact not create the desired outcome from the Compose Basics: Four Quadrants task. The current solution forces the title text to be sticked to the top of they're composable objects, and ignores the vertical centering as shown in the target screenshot. Upon removal of the .padding(bottom = 16.dp) modifier, the title snaps to where it is expected. This was the fix while running the following: Android Studio Narwhal | 2025.1.1 Build #AI-251.25410.109.2511.13665796, built on June 18, 2025 Runtime version: 21.0.6+-13391695-b895.109 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o. Toolkit: sun.lwawt.macosx.LWCToolkit macOS 15.5 Kotlin plugin: K2 mode GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation Memory: 2048M Cores: 10 Metal Rendering is ON Registry: ide.experimental.ui=true com.android.studio.ml.activeModel=com.android.studio.ml.AidaModel Non-Bundled Plugins: com.jetbrains.edu (2025.6-2025.1-1078)
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
I've signed the CLA.
…On Wed, Jul 2, 2025 at 8:20 PM google-cla[bot] ***@***.***> wrote:
*google-cla[bot]* left a comment
(google-developer-training/basic-android-kotlin-compose-training-practice-problems#24)
<#24 (comment)>
Thanks for your pull request! It looks like this may be your first
contribution to a Google open source project. Before we can look at your
pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation
<https://github.com/google-developer-training/basic-android-kotlin-compose-training-practice-problems/pull/24/checks?check_run_id=45255592228>
of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of
the pull request.
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AL3GAHVNFFPOUPAKTKKV6CL3GRZN7AVCNFSM6AAAAACAVKFMH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTAMRZG44TOMZQGM>
.
You are receiving this because you authored the thread.Message ID:
<google-developer-training/basic-android-kotlin-compose-training-practice-problems/pull/24/c3029797303
@github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The solution code does in fact not create the desired outcome from the Compose Basics: Four Quadrants task.
The current solution forces the title text to be sticked to the top of they're composable objects, and ignores the vertical centering as shown in the target screenshot.
Removing the following line from the "title" text composable, fixes this:
modifier = Modifier.padding(bottom = 16.dp),This was the fix while running the following:
Android Studio Narwhal | 2025.1.1
Build #AI-251.25410.109.2511.13665796, built on June 18, 2025 Runtime version: 21.0.6+-13391695-b895.109 aarch64 VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Toolkit: sun.lwawt.macosx.LWCToolkit
macOS 15.5
Kotlin plugin: K2 mode
GC: G1 Young Generation, G1 Concurrent GC, G1 Old Generation Memory: 2048M
Cores: 10
Metal Rendering is ON
Registry:
ide.experimental.ui=true
com.android.studio.ml.activeModel=com.android.studio.ml.AidaModel
Non-Bundled Plugins:
com.jetbrains.edu (2025.6-2025.1-1078)