Skip to content

Update _input_text function to support for non-ASCII characters #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update _input_text function to support for non-ASCII characters #284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions android_env/components/adb_call_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

"""Processes adb_pb2.AdbRequest commands."""

import base64
import os
import re
import subprocess
Expand Down Expand Up @@ -616,8 +617,27 @@ def _input_text(
status=adb_pb2.AdbResponse.Status.FAILED_PRECONDITION,
error_message='InputText.text is empty.')

response, _ = self._execute_command(['shell', 'input', 'text', text],
timeout=timeout)
is_ascii = text.isascii()

if is_ascii:
response, _ = self._execute_command(
['shell', 'input', 'text', text], timeout=timeout
)
else:
b64_text = base64.b64encode(text.encode('utf-8')).decode('ascii')
response, _ = self._execute_command(
[
'shell',
'am',
'broadcast',
'-a',
'ADB_INPUT_B64',
'--es',
'msg',
b64_text,
],
timeout=timeout,
)
return response

def _tap(
Expand Down