Remove socket.error handling.
#263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_730561398
branch
2 times, most recently
from
5d6f5f7 to
a76cad4
Compare
We have no code that raises `socket.error` anymore and we should remove this error handling as it's confusing and irrelevant. This is a relic from the time AndroidEnv used to interact with the Android Emulator via telnet. PiperOrigin-RevId: 730579911
copybara-service
bot
force-pushed
the
test_730561398
branch
from
a76cad4 to
b8e0d77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
socket.errorhandling.We have no code that raises
socket.erroranymore and we should remove thiserror handling as it's confusing and irrelevant. This is a relic from the time
AndroidEnv used to interact with the Android Emulator via telnet.