Draft
Conversation
`IterableMethod::execute` & `ResumableUpload` cause compilation errors.
It reads the entire body into memory instead of implementing Stream.
We need to refactor them to be async.
These features will be passed to reqwest and defaults to rustls-tls to maintain backwards compatibility.
Member
Author
|
I will move 2d58873 to a separate PR sometime soon... |
|
What is the state of this pull request? I would like to use it. |
* master: Repeated method parameters need to be encoded as `field1=value1&field1=value2` Fix predecessor link in README Rearrange the bounds on Client::new() (#26)
|
On my fork I changed to reqwest = { version = "0.11.2", default-features = false, features = ["json"] }to get the latest tokio. Seems to work pretty well for me so far. No other changes were needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR because, although it is fairly usable in its current state (see google-apis-rs/generated@refactor/async), it has some missing functionality:
ResumableUploadto be async (ie update google_rest_api_generator/gen_include/resumable_upload.rs to support async/await)Streaminstead ofIterso it is async (ie replace google_rest_api_generator/gen_include/iter.rs).The above items correspond to
FIXMEcomments in the code.