-
Notifications
You must be signed in to change notification settings - Fork 371
docs: Fix broken links in Go sample README #140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: Fix broken links in Go sample README #140
Conversation
Summary of ChangesHello @bayamasa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses documentation accuracy by fixing broken relative links within a Go sample's README file. The changes ensure that users can correctly navigate to related Python samples and the Go implementation guide, thereby improving the overall usability and reliability of the project's documentation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes two broken links in the Go sample's README file. I've added one suggestion to also correct a third, related link in the same section that points to the main protocol documentation. Applying this suggestion will make the documentation links fully accurate.
- Fix AP2 Protocol Documentation link to point to root README - Fix Python Sample link path (add one more parent directory) - Fix Go Implementation Guide link path (point to samples/go/README.md)
933be87 to
cca630d
Compare
Changes
../../../../python/...\→../../../../../python/...\../../README.md\→../../../../README.md\The paths were incorrect due to missing parent directory levels."
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.Fixes no issues